fix: Disable simulcast when H264 is preferred. #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpolitis
force-pushed
the
fix-h264-regression
branch
from
35893c1
to
1846050
Compare
gpolitis
force-pushed
the
fix-h264-regression
branch
from
1846050
to
b5b08aa
Compare
bbaldino
reviewed
Jul 19, 2017
| @@ -371,8 +371,7 @@ TraceablePeerConnection.prototype.isSimulcastOn = function() { | |||
| // doesn't have a reference to the config options, so we have | |||
| // to do it here | |||
| && (!RTCBrowserType.isFirefox() | |||
| || this.options.enableFirefoxSimulcast) | |||
| && !this.isP2P; | |||
| || this.options.enableFirefoxSimulcast); | |||
There was a problem hiding this comment.
why get rid of the check for p2p in isSimulcastOn? we should not be doing simulcast in p2p, no?
There was a problem hiding this comment.
You're right, we should not be doing simulcast in p2p. I moved the check in JingleSessionPC (in this commit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.