New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .gitattributes to prevent future EOL problems #88
Conversation
I'm always a bit confused how .gitattributes actually works. Shouldn't this be |
no, it will store LF inside git, but let you use CRLF on windows and LF on linux |
According to this link, it should be |
i'm not a windows user so i have no preferences here, we can force LF for *.java |
we can also add 'diff=java' |
Not sure who else uses Windows, but I don't see the point of converting files to CRLF on checkout. It just makes it more likely to cause problems and except for Notepad all editors support LF anyway. Adding diff is fine for me. |
f703afc
to
c69aa33
Compare
i've updated my PRs |
This PR doesn't have the changes. Did you forget you push? |
Hi @ibauersachs, |
Yes, I was referring to the content of the .gitattributes file of libjitsi (the one for Jitsi is merged and I'll look at the mixed content there now). |
Sorry, i must have forget to push (tomorrow) |
Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
c69aa33
to
113d2ba
Compare
hi @ibauersachs, |
Add .gitattributes to prevent future EOL problems
don't forget to cleanup |
my script was only converting mixed EOL (CRLF and LF),
6 files remains with CRLF only, please run
find -name '*.java' | xargs file | grep 'CRLF' | cut -d ':' -f1 | xargs -n1 dos2unix