Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make example work in latest flutter #23

Conversation

rorystephenson
Copy link
Contributor

@rorystephenson rorystephenson commented Apr 25, 2024

This required upgrading gradle.

When run in conjunction with @rise-world's fix in #19 the example app works properly for me on the latest Flutter.

@rorystephenson rorystephenson force-pushed the fix/make-example-work-in-latest-flutter branch from 40460b0 to 5ca40a5 Compare April 25, 2024 15:56
Copy link
Owner

@jiusanzhou jiusanzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pr.

So many packages upgraded, is that necessary?

@rorystephenson
Copy link
Contributor Author

Thank you for your pr.

My pleasure, thank you for the package!

So many packages upgraded, is that necessary?

I bumped the dart version which then forced me to bump the cupertino icons version due to incompatibility. After that I just did flutter pub get and it resulted in those changes.

@jiusanzhou jiusanzhou merged commit 74e4bda into jiusanzhou:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants