Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comprobar que la fecha de los hitos sea anterior #2

Merged
merged 2 commits into from
Oct 12, 2017
Merged

comprobar que la fecha de los hitos sea anterior #2

merged 2 commits into from
Oct 12, 2017

Conversation

AntonioAlcM
Copy link
Contributor

Compruebo que el hito sea anterior a la fecha actual o que se haya creado este día

JJ
JJ requested changes Oct 12, 2017
View reviewed changes
Copy link
Owner

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No estoy muy seguro. El test de este tipo es razonable, pero ¿y si cambia el JSON y pongo una fecha en el futuro? ¿No sería mejor comprobar que las fechas de los hitos están ordenadas o algo así?

JJ
JJ approved these changes Oct 12, 2017
View reviewed changes
Copy link
Owner

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bien, crack.

@JJ JJ merged commit 1161684 into JJ:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JJ JJ JJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonioAlcM @JJ