Skip to content

Commit

Permalink
chore: removes ubuntu 20 image and adds ubuntu 24 image under test. A…
Browse files Browse the repository at this point in the history
…dds node 22 for binary tests and updates node 18 and node 20 to newer feature versions of those releases [run ci] (cypress-io#29412)
  • Loading branch information
AtofStryker authored and jj497 committed May 5, 2024
1 parent eae3fd8 commit dcab354
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
8 changes: 4 additions & 4 deletions system-tests/test-binary/ci_environments_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ describe('e2e binary CI environments', () => {
)

smokeTestDockerImage(
'ubuntu 20 passes',
'cypress/base-internal:ubuntu20-node18', 0,
'ubuntu 22 passes',
'cypress/base-internal:ubuntu22-node18', 0,
)

smokeTestDockerImage(
'ubuntu 22 passes',
'cypress/base-internal:ubuntu22-node18', 0,
'ubuntu 24 passes',
'cypress/base-internal:ubuntu24-node18', 0,
)
})
10 changes: 6 additions & 4 deletions system-tests/test-binary/node_versions_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,17 @@ function smokeTestDockerImage (dockerImage: string) {

describe('binary node versions', () => {
[
'cypress/base:18.15.0',
'cypress/base:20.5.0',
'cypress/base:18.16.1',
'cypress/base:20.12.2',
'cypress/base:22.0.0',
].forEach(smokeTestDockerImage)
})

describe('type: module', () => {
[
'cypress/base:18.15.0',
'cypress/base:20.5.0',
'cypress/base:18.16.1',
'cypress/base:20.12.2',
'cypress/base:22.0.0',
].forEach((dockerImage) => {
systemTests.it(`can run in ${dockerImage}`, {
withBinary: true,
Expand Down

0 comments on commit dcab354

Please sign in to comment.