Updates vlm for more recent gcc and libcrypt #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On newer versions of libcrypt, `encrypt` does not have default version name so the configure check fails. However, the only place we import <crpyt.h> (life-support/unixcrypt.c) calls `crypt()` not `encrypt()` and crypt does have a default version. This updates the configure.ac file to check for the function we actually need
…ration Newer versions of gcc require pointer typed values for computed goto. This casts the u64 pointer values to void* for the goto instructions.
|
Maybe off-topic for the issue; but I'd recommend sun-setting any work on OG in favor of the MIT / LM-3 CADR (http://tumbleweed.nu/lm-3/). Both do more or less the same, and the CADR has no software hoarders hounding it, on top of that the whole System can be recompiled and bootstrapped. For the MIT CADR there is also a entirely unencumbered MACSYMA, CAD (NewDRAW) and bunch of other fun stuff. |
|
Might also add that this will not make the OG2.0 world image work on modern systems due to changes in XLIB and other nonsense. I have notes if someone wants them. This version of VLM also contains numerous bugs in the FP and other parts ... also fixed many years ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configurechecks for the presences oflibcrypt.soby testing for the existence ofencrypt(), butencrypt()no longer has a default .so version. However, onlylife-support/unixcrypt.cdepends on<crypt.h>and rather than callingencrypt(), it callscrypt()which does have a default.soversion. Changing this allowsconfigureto discover the presence oflibcrypt.sogoto. This casts theu64pointer values tovoid*for the goto instructions for the C implementations ofjmpandretwhich are e.g.goto *r0calls intogoto *((void*) r0)calls