Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor cleanup comments #4

Closed
kramvan1 opened this issue Oct 10, 2014 · 1 comment
Closed

Some minor cleanup comments #4

kramvan1 opened this issue Oct 10, 2014 · 1 comment

Comments

@kramvan1
Copy link
Collaborator

environments / example.rb
line 2, mention osops-utils cookbook, but don't see that called out anywhere.
line 2, maybe rewrite with multilines?

environments / testing.rb
line 2, maybe describe the basic env here? Nova Network, single controller, all-in-one?
line 23,179, 237, debug true? is this really needed? either across all or none.
line 86, maybe move this to top to make it easier to find?
line 17,18 syslog use is false by default, why need to set this? remove?
line 28, under Compute, I always add enabled_apis: 'osapi_compute' to limit the apis to just what we need.

roles
missing os-client, some telemetry ones

roles / allinone-compute.json
Maybe consider adding "recipe[openstack-common::openrc]" for completeness?
Maybe consider adding "role[os-client]" for completeness? (would need to add this role)

.gitignore
Add berks-cookbooks/
Add .kitchen
Add .bundle
Add .vargrant

Berksfile
Maybe bump openssl to 2.0.0 (where some security issues in there)

Gemfile

Maybe bump Chef to 11.16?
Maybe bump Berkshelf to 3.1.5?
Add versions for Chef-metal and -vagrant, need to be more strict for repo stuff.

Readme
Maybe upfront explain that current this is focused on centos and icehouse.
Some Refs to the old singlestack project
Hopefully soon we can pull the UTF8 image uglyness. Maybe update refs to cookbook patches
openrc is now a recipe, maybe you should try using that instead of manual creating it.
TODO for test after setup. Just call source /root/openrc, then call "openstack-status" It will give the basics to see if all is up and running.
After Boot that image, would be nice to show commands to verify that the image is up and running properly. nova status? ssh into it? dashboard console login? ping it? ping from it?

@jjasghar
Copy link
Owner

I've made some major changes but not hit each of these. I'll close this for now, and attempt to make these changes now.

jjasghar pushed a commit that referenced this issue Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants