Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ssl_ciphers #255

Merged
merged 1 commit into from Apr 23, 2015
Merged

Added ssl_ciphers #255

merged 1 commit into from Apr 23, 2015

Conversation

kramvan1
Copy link
Contributor

Allow ssl ciphers to be configured

@kramvan1
Copy link
Contributor Author

@jjasghar This is another one we would like to get in this week, it's also just basic config options.

@kramvan1
Copy link
Contributor Author

@cmluciano @jjasghar Humm, seems travis failure is NOT related to this change, but rather to this one: #236 Looks like we pulled out the case to include the yum-epel and yum-erlang, but did not cleanup the specs or the metadata.

@cmluciano
Copy link
Collaborator

Yes that was on purpose. The tests passes with my changes. The reason that they are failing now is due to the removal from the erlang package recipe change.

@kramvan1
Copy link
Contributor Author

@cmluciano thx for the update. I have removed those tests from the spec with my latest push.

@@ -56,6 +56,12 @@
:mode => 00644)
end

it 'allows ssl ciphers' do
node.set['rabbitmq']['ssl_ciphers'] = ['ecdhe_ecdsa,aes_128_cbc,sha256', 'ecdhe_ecdsa,aes_256_cbc,sha']
expect(chef_run).not_to render_file('/etc/rabbitmq/rabbitmq.config').with_content(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me or not_to should have been to here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, will clean that up and add in the default case of no specific ciphers.

Allow ssl ciphers to be configured
Also minor cleanup for spec with yum
jjasghar pushed a commit that referenced this pull request Apr 23, 2015
@jjasghar jjasghar merged commit 09d2ec2 into rabbitmq:master Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants