Fix change node type #263
Closed
Fix change node type #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This action would fail each time it tried to change the cluster type. Once I changed it to each, it now performed the task correctly
…disc type, this would break on a second run of chef-client. I made sur ethat it validated if it indeed found a ram or a disc type
|
👍 |
|
Hi @linuxdynasty! Can you please update your PR to replace |
|
I take a look at tests. For now it seems there is very few tests related to the cluster part. |
| @@ -89,7 +93,11 @@ def disc_nodes(cluster_status) | |||
| pattern = '({disc,\[)(.*?)(\]})' | |||
| result = match_pattern_cluster_status(cluster_status, pattern) | |||
| Chef::Log.debug("[rabbitmq_cluster] disc_nodes : #{result}") | |||
| result.split(',') | |||
| if result.nil? | |||
| result = [] | |||
There was a problem hiding this comment.
Rubocop doesn't like this :(
|
I'm going to close this due to no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the action change_node_type and as well not break on a 2nd run, since provider expected that a ram type will always be in the output of cluster_status