Allow for flexiable SSL cipher formats #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current cookbook (my bad) forced the ssl cipher format to be enclosed
with single quotes. This turns out to be almost a completely invalid
way of specifying ssl ciphers. This patch removes those quotes and
leaves it up to the user to specify ssl ciphers and any of the various
formats, like those used in the spec and shown below.
Using erlang style cipher suite configuration,
(see output of command rabbitmqctl eval 'ssl:cipher_suites(erlang)',
which is lower cases with {}:
node['rabbitmq']['ssl_ciphers'] =
%w({ecdhe_ecdsa,aes_256_cbc,sha384} {ecdh_ecdsa,aes_256_cbc,sha384})
Using UPPERCASE cipher constants:
node['rabbitmq']['ssl_ciphers'] =
%w("ECDHE-ECDSA-AES256-SHA384" "ECDH-ECDSA-AES256-SHA384")
|
I'm planning on releasing another version of the rabbitmq cookbook this by end of week |
|
@jjasghar thx, getting this one out of the way would be great! 👍 |
openstack-gerrit
pushed a commit
to openstack-archive/cookbook-openstack-ops-messaging
that referenced
this pull request
Jul 25, 2015
from pull request: rabbitmq/chef-cookbook#280 Change-Id: Ie803255049b44ceaa7e4715db2a5e4cc70a78c31 Related-Bug: #1465846
openstack-gerrit
pushed a commit
to openstack-archive/openstack-chef-repo
that referenced
this pull request
Jul 27, 2015
from pull request: rabbitmq/chef-cookbook#280 Depends-On: Ie803255049b44ceaa7e4715db2a5e4cc70a78c31 Change-Id: Ibc74640f9b8bf26815918e5c9da2c4245e691d31 Related-Bug: #1465846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current cookbook (my bad) forced the ssl cipher format to be enclosed with single quotes. This turns out to be almost a completely invalid way of specifying ssl ciphers. This patch removes those quotes and leaves it up to the user to specify ssl ciphers in any of the various formats, like those used in the spec and shown below.
Using erlang style cipher suite configuration, (see output of command rabbitmqctl eval 'ssl:cipher_suites(erlang)', which is lower cases with {}:
node['rabbitmq']['ssl_ciphers'] = %w({ecdhe_ecdsa,aes_256_cbc,sha384} {ecdh_ecdsa,aes_256_cbc,sha384})
Using UPPERCASE cipher constants:
node['rabbitmq']['ssl_ciphers'] = %w("ECDHE-ECDSA-AES256-SHA384" "ECDH-ECDSA-AES256-SHA384")