forked from thoughtbot/trail-map
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[thoughtbot#5] Add Code Review trail
- Loading branch information
Adarsh Pandit
authored and
Dan Croak
committed
Sep 23, 2012
1 parent
8f400e0
commit e46792c
Showing
2 changed files
with
28 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
Code Review | ||
=========== | ||
|
||
Critical Learning | ||
----------------- | ||
|
||
* Read [feature branch code reviews](http://goo.gl/jIcOv). | ||
* Read [Best Practices of Peer Code Review](http://goo.gl/A8Boc). | ||
|
||
Validation | ||
---------- | ||
|
||
You know how to review code when you can: | ||
|
||
* Comment on a specific line number. | ||
* Comment constructively and politely. | ||
* Learn something valuable from the comments. | ||
* Express appreciation to the author. | ||
* Respond the request in a timely manner. | ||
|
||
You know how to have your code reviewed when you can: | ||
|
||
* Create small pull requests, which are easier to review. | ||
* Take comments as constructive and not personal criticism. | ||
* Learn something valuable from the comments. | ||
* Express appreciation to the reviewer. | ||
* Respond to comments in a timely manner. |