Skip to content

Commit

Permalink
[thoughtbot#5] Add Code Review trail
Browse files Browse the repository at this point in the history
  • Loading branch information
Adarsh Pandit authored and Dan Croak committed Sep 23, 2012
1 parent 8f400e0 commit e46792c
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Expand Up @@ -29,6 +29,7 @@ Trails
------

* [CSS](/thoughtbot/trail-map/blob/master/trails/css.md)
* [Code Review](/thoughtbot/trail-map/blob/master/trails/code-review.md)
* [Git](/thoughtbot/trail-map/blob/master/trails/git.md)
* [Grids](/thoughtbot/trail-map/blob/master/trails/grids.md)
* [HTML](/thoughtbot/trail-map/blob/master/trails/html.md)
Expand Down
27 changes: 27 additions & 0 deletions trails/code-review.md
@@ -0,0 +1,27 @@
Code Review
===========

Critical Learning
-----------------

* Read [feature branch code reviews](http://goo.gl/jIcOv).
* Read [Best Practices of Peer Code Review](http://goo.gl/A8Boc).

Validation
----------

You know how to review code when you can:

* Comment on a specific line number.
* Comment constructively and politely.
* Learn something valuable from the comments.
* Express appreciation to the author.
* Respond the request in a timely manner.

You know how to have your code reviewed when you can:

* Create small pull requests, which are easier to review.
* Take comments as constructive and not personal criticism.
* Learn something valuable from the comments.
* Express appreciation to the reviewer.
* Respond to comments in a timely manner.

0 comments on commit e46792c

Please sign in to comment.