Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code examples #36

Merged
merged 1 commit into from
Oct 28, 2018
Merged

Improve code examples #36

merged 1 commit into from
Oct 28, 2018

Conversation

noplanman
Copy link
Contributor

Touch up and complete code examples, adhering mostly to WordPress style guide.

The main thing that I haven't added are inline comments ending with periods and the spaces between parenthesis:

// An inline comment here
$following = __('This style');

// A WP styled comment.
$following = __( 'WP style' );

@jjgrainger Shall I change them all to make it 100% WP style guide compatible?

@noplanman noplanman mentioned this pull request Oct 25, 2018
@jjgrainger
Copy link
Owner

@noplanman Thanks for this, I'm happy with the changes you've made.

Maybe we could review the updating code examples to 100% adhere to the WP style guide later. For now, I would like to get all your pulls merged to benefit from the great work you've done!

Thanks 👍

@jjgrainger jjgrainger merged commit df30d7e into jjgrainger:master Oct 28, 2018
@noplanman noplanman deleted the docs/code-examples branch October 28, 2018 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants