Refactor tests. Fix file closing issue. #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly close files. - Better support for windows platform. - remove redundant code
|
Thanks @brycedrennan, this is really great! There's a lot of changes here, so I want to give it a careful review. I'll be in touch soon, thanks again! : ) |
|
Thanks. I see it changed file permissions. I'll fix that. |
|
Everything looks good to me. Thanks again @brycedrennan. A lot of people have been asking for better Windows support for a bit now, and the tests were indeed quite messy. This is really helpful. Please feel free to add yourself to https://github.com/jjjake/internetarchive/blob/master/AUTHORS.rst, if you'd like! : ) |
This was referenced Nov 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to cleanup some the code a bit before adding some bugfixes.