Skip to content

Commit

Permalink
tests: add more coverage for logger
Browse files Browse the repository at this point in the history
  • Loading branch information
jjjermiah committed Feb 5, 2024
1 parent a6f40cc commit b90c74c
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 7 deletions.
11 changes: 4 additions & 7 deletions src/nbiatoolkit/logger/logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,10 @@ def setup_logger(

# Set up console handler if console_logging is True
if console_logging:
try:
console_handler = logging.StreamHandler()
console_handler.setFormatter(formatter)
console_handler.setLevel(level)
logger.addHandler(console_handler)
except Exception as e:
raise IOError(f"Error setting up console handler for logger: {e}") from e
console_handler = logging.StreamHandler()
console_handler.setFormatter(formatter)
console_handler.setLevel(level)
logger.addHandler(console_handler)

return logger

Expand Down
14 changes: 14 additions & 0 deletions tests/test_logger.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import logging
import os
from logging.handlers import TimedRotatingFileHandler

import pytest
from nbiatoolkit.logger.logger import setup_logger

def test_setup_logger_name():
Expand Down Expand Up @@ -44,3 +46,15 @@ def test_setup_logger_log_dir():

# close the file handler
logger.handlers[0].close()

def test_invalid_log_level():
# Test case 6: Verify that an error is raised for an invalid log level
try:
setup_logger("test_logger6", log_level="INVALID")
except ValueError as e:
assert str(e) == "Invalid log level: INVALID"

def test_invalid_log_file():
# Test case 7: Verify that an error is raised for an invalid log file
with pytest.raises(IOError):
setup_logger("test_logger7", log_file="/invalid/log/file.log")

0 comments on commit b90c74c

Please sign in to comment.