fix: tests Add error handling for response code 204 and fix typo in t…

…est_getDICOMTags

src/nbiatoolkit/utils/parsers.py

@@ -98,6 +98,7 @@ def parse_response(response: requests.Response) -> List[dict[Any, Any]]:
     assert (
         response.status_code == 200
     ), "The response status code must be 200 OK but is {}".format(response.status_code)
+    # TODO:: describe error 204
 
     if not "application/json" in content_type:
         if response.content == b"":

tests/test_nbia_series_functions.py

@@ -59,6 +59,14 @@ def getSeriesMetadata(nbia_client):
     return series_metadata
 
 
+def test_getSeriesMetadata_failed(nbia_client):
+    with pytest.raises(Exception) as e:
+        series = "1.3.6.1.4.1..1.9203.4004.652695091345533290618011349477"
+        series_metadata = nbia_client.getSeriesMetadata(
+            SeriesInstanceUID=series, return_type="dataframe"
+        )
+
+
 @pytest.fixture(scope="session")
 def getNewSeries_metadata(nbia_client):
     Date = "01/01/2024"
@@ -90,6 +98,12 @@ def test_failed_getNewPatients(nbia_client):
         )
 
 
+def test_failed_getDICOMTags(nbia_client):
+    with pytest.raises(Exception) as e:
+        # collection isntead of Collection
+        nbia_client.getDICOMTags(series="ShouldFail", return_type="dataframe")
+
+
 def test_getNewPatients(nbia_patients_df):
 
     assert isinstance(nbia_patients_df, pd.DataFrame)

tests/test_parsers.py

@@ -1,4 +1,9 @@
-from src.nbiatoolkit.utils.parsers import clean_html, convertMillis, convertDateFormat
+from src.nbiatoolkit.utils.parsers import (
+    clean_html,
+    convertMillis,
+    convertDateFormat,
+    parse_response,
+)
 from datetime import datetime
 import pytest