Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more django style AUTH_USER_MODEL setting and some utils #1

Merged
merged 3 commits into from
Dec 11, 2013

Conversation

francofuji
Copy link
Contributor

No description provided.

@jjkester
Copy link
Collaborator

First off, thank you for contributing. I find your suggestions useful.

I was already going to write a method that displays changes in HTML, I just did not do it yet. Personally I think it would be better to make it more flexible, for example, your solution will not be useful in a project I am working on now because the output will not fit in the view. In general, I think no Django app should limit its users in the way their application should look, therefore a more flexible solution is preferred.

Also, you made a slight typo in the method name.

jjkester added a commit that referenced this pull request Dec 11, 2013
Merge pull request #1 from francofuji/master
- Make AUTH_USER_MODEL work with 'app_label.model_name' format
- Some util functions
- Log an entry only if there are changes
@jjkester jjkester merged commit dac120b into jazzband:master Dec 11, 2013
@jjkester
Copy link
Collaborator

After some consideration I decided to simply write a method that creates a dict based on the changes for the object and a method that parses this into a string. In my opinion HTML formatting should be done in either a template or a template tag/filter (I did not [yet] create one of those).

jjkester pushed a commit that referenced this pull request Oct 13, 2016
dawalama pushed a commit to rocketrip/django-auditlog that referenced this pull request Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants