Skip to content

Commit

Permalink
Disambiguate left/right, document ->keys, make Kwalitee test autoskip
Browse files Browse the repository at this point in the history
  • Loading branch information
kentfredric committed Sep 12, 2009
1 parent 338528f commit c046e43
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
10 changes: 7 additions & 3 deletions lib/Spark/Form.pm
Expand Up @@ -292,13 +292,13 @@ sub clone_except_names {
}

sub _except {
my ($self, $left, $right) = @_;
my ($self, $input_list, $exclusion_list) = @_;
my %d;
@d{@{$left}} = ();
@d{@{$input_list}} = ();

return grep {
!defined $d{$_}
} @{$right};
} @{$exclusion_list};
}

sub clone_only_names {
Expand Down Expand Up @@ -473,6 +473,10 @@ Returns the form field of that name
Returns the form field at that index (counting from 0)
=head2 keys () :: Array
Returns the field names
=head2 field_couplet () :: Data::Couplet
Returns the Data::Couplet used to store the fields. Try not to use this too much.
Expand Down
6 changes: 5 additions & 1 deletion xt/author/kwalitee.t
@@ -1,6 +1,10 @@

use strict;
use warnings;

use Test::More;

BEGIN {
eval { require Test::Kwalitee; 1 }
or plan skip_all => "You need Test::Kwalitee installed to run this test. Its only an authortest though, so thats ok";
}
use Test::Kwalitee tests => [qw( -use_strict )];

0 comments on commit c046e43

Please sign in to comment.