Tests fail with File::ShareDir::ProjectDistDir 0.5.2

[patmooney]

Tests run with this error: Can't find a share () for Local

The new version of ProjectDistDir no longer looks for a lib/ directory to dictate the project root/ so the share/ directory is not being correctly located in t/

File::ShareDir::ProjectDistDir 0.5.2 searches upwards of the given module and looks for any of the following

META.json
META.yml
Change(s|log)(|[.][^.\s]+)
GNUmakefile
makefile
Makefile
.devdir
t/
xt/
MYMETA.json
MYMETA.yml
dist.ini
Makefile.PL
Build.PL

[patmooney]

Placing a .devdir file in t/ directory seems to work quite nicely

[jjn1056]

Hey,

Thanks for pointing this out!  I'm in the middle of a big move, so will take a look as soon as I can get to it.  I am honestly a bit unhappy with this change in ProjectDistDir... I'll have to try and understand that.  Thanks!

John

---

From: patmooney notifications@github.com
To: jjn1056/DBIx-Class-Migration DBIx-Class-Migration@noreply.github.com
Sent: Thursday, September 26, 2013 9:47 AM
Subject: [DBIx-Class-Migration] Tests fail with File::ShareDir::ProjectDistDir 0.5.2 (#35)

Tests run with this error: Can't find a share () for Local
The new version of ProjectDistDir no longer looks for a lib/ directory to dictate the project root/ so the share/ directory is not being correctly located in t/
File::ShareDir::ProjectDistDir 0.5.2 searches upwards of the given module and looks for any of the following
META.json
META.yml
Change(s|log)(|[.][^.\s]+)
GNUmakefile
makefile
Makefile
.devdir
t/
xt/
MYMETA.json
MYMETA.yml
dist.ini
Makefile.PL
Build.PL
—
Reply to this email directly or view it on GitHub.

[vkroll]

Had the same issue, the .devdir File in t/ works

[jjn1056]

@vkroll , @patmooney hey so I finally have some time clear to look at this, but sadly I can't replicate the issue. I've installed the newest ::ProjectDistDir and all. Can one of you add in comment the complete run and fail, and the steps you take to generate it, that way I can track it down. Thanks --John

[patmooney]

A rather drawn out method:
cpanm -L local DBIx::Schema::Migration

Use of uninitialized value $sharedir in concatenation (.) or string at /home/patrick/.cpanm/work/1381256651.7654/DBIx-Class-Migration-0.041/blib/lib/DBIx/Class/Migration/ShareDirBuilder.pm line 33.

[patmooney]

I the specific issue is with Path::IsDev and should have made that clear so I apologise!

[jjn1056]

I thought I did a totally clean local lib and should have gotten the new Path::IsDev

Ok I will try again!

thanks!!!! -john

On Tuesday, October 8, 2013 1:32 PM, patmooney notifications@github.com wrote:

I the specific issue is with Path::IsDev and should have made that clear so I apologise!
—
Reply to this email directly or view it on GitHub.

[jjn1056]

Well, I can't replicate this issue no matter what, but I'll just go ahead and do a release with that t/.devdir and hope it just works. Let me know! --John

[agorman]

I believe Dist::Zilla::Plugin::PruneCruft is removing t/.devdir in your new release