Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stretchr/testify with self-written asserts #6

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Replace stretchr/testify with self-written asserts #6

merged 1 commit into from
Jan 9, 2024

Conversation

alexandear
Copy link
Contributor

This PR removes the dependency github.com/stretchr/testify. It's used only in config_test.go and no need to include the whole powerful package for using only one function require.Equal.

@jjti
Copy link
Owner

jjti commented Jan 9, 2024

Looks good to me and makes sense, @alexandear . Thanks again!

@jjti jjti merged commit 6b201ef into jjti:main Jan 9, 2024
2 of 3 checks passed
@alexandear alexandear deleted the config-test-remove-testify branch January 9, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants