Add ability to whitelist certain keys from state #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plwai
requested review from
jk-gan and
plwai
and removed request for
jk-gan
plwai
approved these changes
Sep 22, 2020
|
All right so merge and new release? |
I will merge it and publish it to npm later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We noticed same slowness as issue #27 . The reason for slowness is that if your app has huge Redux state then Flipper is making app veeeeryyyy slow. Solution for this is it only watch certain keys of your Redux state.
This change is necessary in any way since often times in big production apps the store has 30 different root keys and you are only interested only in one when debugging. And you can still see the whole state if you want if you don't specify
stateWhitelistHow to test?
Add
stateWhitelistto your configuration and add some keys to the array which are included in your Redux state and see from Flipper app that only that part of the state is logged on actionsFixes #27