Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to modules. #16

Closed
wants to merge 2 commits into from
Closed

Move to modules. #16

wants to merge 2 commits into from

Conversation

nathanhammond
Copy link
Collaborator

ember-cli-defeatureify presently requires globals since the processing for feature stripping does a string comparison on the variable path. This PR implements a solution that allows for importing of the feature configuration as a module and removes globals. As a consequence there is no longer any need to specify namespace as that will consistently be the module name.

This also dramatically reduces the complexity of the addon. I've also ported it to an up-to-date blueprint.

Depends on ember-cli/ember-cli#5233 landing in order to support configuration in a meta tag.

Closes #15.

@nathanhammond
Copy link
Collaborator Author

Also, @jkarsrud, I've added you as a collaborator to my fork in case you want to modify this PR so you can do so directly in my fork.

@jkarsrud
Copy link
Owner

jkarsrud commented Mar 6, 2016

@nathanhammond I've given you commit access to this repo now, so feel free to do changes as you wish. I don't really use this addon anymore, so it's better if someone who actually does maintains it :)

@nathanhammond
Copy link
Collaborator Author

@jkarsrud Awesome, thanks! We're still looking for the world's most ridiculous bug which is preventing ember-cli/ember-cli#5233 from landing, but that's really the only thing left.

@erkie
Copy link

erkie commented May 17, 2017

Any chance of getting this merged? Looking forward to getting rid of the deprecation:

DEPRECATION: The `app-prefix` hook used in ember-cli-defeatureify is deprecated. The addon should generate a module and have consumers `require` it.

:D

@nathanhammond nathanhammond closed this by deleting the head repository Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants