Fill in cr->rg when writing CRAM v1

As per the other branches of the if-else, set cr->rg. Also rewrite the assert: the previous code produced "brg is unused" warnings when compiled with -DNDEBUG.
jkbonfield · Nov 2, 2021 · f674651 · f674651
1 parent 7060387
commit f674651
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/cram/cram_encode.c b/cram/cram_encode.c
@@ -3057,7 +3057,8 @@ static int process_one_read(cram_fd *fd, cram_container *c,
         cr->rg = brg ? brg->id : -1;
     } else if (CRAM_MAJOR_VERS(fd->version) == 1) {
         sam_hrec_rg_t *brg = sam_hrecs_find_rg(fd->header->hrecs, "UNKNOWN");
-        assert(brg);
+        if (!brg) goto block_err;
+        cr->rg = brg->id;
     } else {
         cr->rg = -1;
     }