Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XML pretty-print formatting. Fixes #389. #394

Closed
wants to merge 1 commit into from

Conversation

analytically
Copy link

XML parsing with Python is problematic:

  • comments are by default ignored
  • unable to set indent spacing in lxml
  • various compability issues with ElementTree between python 2.6, 2.7 and 3.4.

Best just remove the pretty printing.

…omment support across multiple Python version is problematic. Fixes httpie#389.
@analytically analytically changed the title Support namespaced XML. Pretty print XML comments too. Fixes #389. Remove XML pretty-print formatting. Fixes #389. Oct 21, 2015
@jkbrzt jkbrzt mentioned this pull request Feb 28, 2016
5 tasks
@jkbrzt jkbrzt closed this in 293295c Mar 18, 2016
@deed02392
Copy link

Can we revisit this feature? There must be a decent library for pretty printing XML, including preserving comments etc.. And even if not, it would be better to just for example compare the output length versus the input length (minus whitespace) to get a good idea on whether tidying succeeded. If it didn't just warn and show the original response body.

@jkbrzt jkbrzt mentioned this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants