Time Zone Support #97

aramk · 2015-05-03T06:20:00Z

This uses some of the methods in #78 and is an implementation of what was discussed in #38.

I've created a separate library at tz-date which contains a TimeZoneDate that extends Date, adheres to its API, has Mocha tests, and supports time zones through http://momentjs.com/timezone. This is in CoffeeScript so you'll need to run bower install in rrule and then grunt build in bower_components/tz-date to generate the JavaScript used by the tests I've added.

Since Date doesn't support having a time zone as the last argument and returns Invalid Date, I've
created a new method called createDate() to handle this situation. All date creation in the
library is now handled through this method. This also adds a "timezone" option which is passed to
all calls of createDate().

As for the testing, tests/index.html will still work as before and use Date. In tests/timezone.html
I add TimeZoneDate and its dependency libraries, and in timezone-tests I set TimeZoneDate as the
custom Date class to use. Here I've tests two time zones - my home city of Melbourne and
Los Angeles. TimeZoneDate has its own Mocha tests to ensure the getters and setters behave correctly.
For maximum coverage I've also ensured the existing tests are run with TimeZoneDate, so I'm fairly
convinced it's working well :)

One thing we might want to standardise is whether to use timeZone or timezone. I've been using
the "time zone" convention on the Wikipedia page, but "timezone" is fairly common elsewhere,
especially in libraries, and moment-timezone's docs use it interchangeably... Not sure which is
"correct", but standardising will reduce the confusion.

I hope this can be merged since it adds a vital feature which is missing from this library and which
likely impacts many people who are building apps and deploying them across the world. If not, this
branch is here for everyone to use.

…hods to dateutil.

* master: Added check for invalid dates in init(). Added isValid and isDate methods to dateutil.

* mattcasey-master: add ability to use utility to supply timezoneoffset Fix typo Do not hang if interval is 0 or not a number Conflicts: lib/rrule.js

Added compiled MomentDate for testing and created a separate html file for testing with existing test suite.

Added test for using MomentDate with RRule.

…etermining whether to use time zones or local dates. Added method for getting duck-typed time zone from dates. Added tz-date library for testing time zone support. Removed old MomentDate. Added tests for between and between in Melbourne.

Fixed timezone support in toString() and fromString(). Added timezone to IterResult. Added back timezone tests and fixed issues causing infinite loops.

# By Linquize (2) and others # Via Jakub Roztočil (4) and Jakub Roztocil (2) * 'master' of https://github.com/jakubroztocil/rrule: Undo jkbrzt#91 as it was breaking the demo app Allow Negative and 2-Digit Values in Demo Bugfix Fix typo Do not hang if interval is 0 or not a number Updating script location in Bower, fixes jkbrzt#61.

* 'master' of https://github.com/aramk/rrule: Renamed isValid() to isValidDate().

* master: Renamed isValid() to isValidDate(). Undo jkbrzt#91 as it was breaking the demo app Allow Negative and 2-Digit Values in Demo Bugfix Updating script location in Bower, fixes jkbrzt#61. Conflicts: bower.json lib/rrule.js

fampinheiro · 2015-06-05T16:54:25Z

Any updates regarding this?

aramk · 2015-06-06T01:45:06Z

I've been using this in production and it's been working fine. I've added tests, it's just a question of whether this is eventually merged in or not.

jamesdixon · 2016-05-17T23:47:59Z

@aramk I'm going to give your fork a shot. I see there a specific branch that is more up-to-date than others? I see one with stable appended to the name, so was curious.

Thanks!

aramk · 2016-05-18T01:15:36Z

@jamesdixon Yeah the feature/timezone-stable is older and the timezone branch is based off that. I'm using feature/meteor which has a few other fixes actually.

aramk · 2016-05-18T01:16:29Z

Removed feature/timezone-stable to avoid confusion

jamesdixon · 2016-05-18T01:17:13Z

Thanks @aramk! Going to give it a shot. Is there a good place in the repo to grab an example?

jamesdixon · 2016-05-18T01:19:27Z

Nevermind, I see the tests. Thanks!

aramk · 2016-05-18T01:20:15Z

Yeah, see
https://github.com/aramk/rrule/blob/feature/meteor/tests/timezone-tests.js

On Wed, May 18, 2016 at 11:19 AM James Dixon notifications@github.com
wrote:

Nevermind, I see the tests. Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#97 (comment)

Sutikshan · 2016-07-06T21:57:05Z

Thanks @aramk , I am trying to use your fork in production for our purpose. There are few obstacle I am facing -

I am not able to run tests cases, when I try $grunt test, it is failing with error
Error: Cannot find module 'tz-date'
Though tz-date is present inside node_modules folder. any clue?
When I try to use it in our project as following, it get stuck inside infinite loop of _iter function

new Rrule("FREQ=WEEKLY;BYDAY=FR;BYHOUR=15;BYMINUTE=0;TIMEZONE=Australia/Perth").after(new Date)

Is Dtstart/until are mandatory attribute, if we use your fix?

aramk · 2016-07-13T04:22:30Z

@Sutikshan I think dtstart is mandatory so we have a starting date for the recurrence, and if you don't provide an until it will run endlessly? As far as I can tell I haven't changed the behaviour or interface for the plugin. All existing tests are passing for me on this hash.

arolson101 · 2018-02-14T18:36:40Z

Hi! I'm trying to clear out bugs and PRs. If this PR is still wanted/relevant, please comment and/or fix the conflicts!

davidgoli · 2018-08-13T20:57:33Z

This will be addressed in a separate PR.

aramk and others added 21 commits June 8, 2014 20:15

Added support for using the package in Meteor.

817b9a3

Added global RRule to Meteor using the recommended method.

b0e7a43

Added files to both client and server.

f9b0a6b

Added check for invalid dates in init(). Added isValid and isDate met…

5502d02

…hods to dateutil.

Merge branch 'master' into feature/meteor

dc97c4c

* master: Added check for invalid dates in init(). Added isValid and isDate methods to dateutil.

Updated package details.

f04503e

add ability to use utility to supply timezoneoffset

d0b187a

Merge branch 'mattcasey-master' into feature/meteor-timezone-stable

fa4efdb

* mattcasey-master: add ability to use utility to supply timezoneoffset Fix typo Do not hang if interval is 0 or not a number Conflicts: lib/rrule.js

Moved setDateClass() into RRule namespace.

9314a88

Ensured dtstart is always created with the timezone option.

bb46730

Fixed bugs dealing with custom Date class.

d69a3ec

Added compiled MomentDate for testing and created a separate html file for testing with existing test suite.

Fixed implementation of MomentDate.

cfaeed7

Added test for using MomentDate with RRule.

Renamed isValid() to isValidDate().

031734c

Added support for variadic arguments for createDate().

03d6547

Added timezone to all remaining dates without it.

808e058

Fixed timezone support in toString() and fromString(). Added timezone to IterResult. Added back timezone tests and fixed issues causing infinite loops.

Merge branch 'master' of https://github.com/aramk/rrule

268970b

* 'master' of https://github.com/aramk/rrule: Renamed isValid() to isValidDate().

Merge branch 'master' into feature/timezone

b21afa3

* master: Renamed isValid() to isValidDate(). Undo jkbrzt#91 as it was breaking the demo app Allow Negative and 2-Digit Values in Demo Bugfix Updating script location in Bower, fixes jkbrzt#61. Conflicts: bower.json lib/rrule.js

Ensured all dates are created as TimeZoneDate during timezone tests.

b4e16e5

Added docs for createDate().

93a46b0

This was referenced May 3, 2015

allow ability to provide timezone support via custom Date class #78

Closed

Time Zone Support #38

Closed

aramk added 2 commits May 3, 2015 16:26

Reverted unnecessary changes to package.json.

fde7e20

Added version for tz-date.

90a26fc

davidgoli closed this Aug 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Time Zone Support #97

Time Zone Support #97

aramk commented May 3, 2015

fampinheiro commented Jun 5, 2015

aramk commented Jun 6, 2015

jamesdixon commented May 17, 2016

aramk commented May 18, 2016

aramk commented May 18, 2016

jamesdixon commented May 18, 2016

jamesdixon commented May 18, 2016

aramk commented May 18, 2016

Sutikshan commented Jul 6, 2016 •

edited

aramk commented Jul 13, 2016 •

edited

arolson101 commented Feb 14, 2018

davidgoli commented Aug 13, 2018

Time Zone Support #97

Time Zone Support #97

Conversation

aramk commented May 3, 2015

fampinheiro commented Jun 5, 2015

aramk commented Jun 6, 2015

jamesdixon commented May 17, 2016

aramk commented May 18, 2016

aramk commented May 18, 2016

jamesdixon commented May 18, 2016

jamesdixon commented May 18, 2016

aramk commented May 18, 2016

Sutikshan commented Jul 6, 2016 • edited

aramk commented Jul 13, 2016 • edited

arolson101 commented Feb 14, 2018

davidgoli commented Aug 13, 2018

Sutikshan commented Jul 6, 2016 •

edited

aramk commented Jul 13, 2016 •

edited