Handle numbers in action/type names

[ahwatts]

A recent update to reduxsauce's making of type names broke our code because it changed the way it was handling numbers in the type name.

We have an action, storeS3Key, which we were expecting to be translated to STORE_S3_KEY. However, with the change to the regex that converts to SCREAMING_SNAKE_CASE, it was being translated to STORES3_KEY. This PR changes that to treat numbers as being part of the preceding word.

[jkeam]

Great enhancement! Question about the package-lock file, any reason for checking it in? Also question about the package.json, any reason for adding the 'prepare' script?

[ahwatts]

Sorry, I saw this and forgot about it for a few days. The package.json change with the prepare script was added so that I could install the package directly from the git repo. The package-lock.json file was probably checked in by accident. Neither of those changes is substantive, and I (or you) can drop them if you'd like.

[jkeam]

Hi I was looking to drop the package.json and package-lock.json as well as a small edit to change the * to a + in your PR (like the regex was before). I don't mind doing it, but can you double check to make sure that edits by the maintainers are allowed? Or you can do it if you prefer. Just let me know!

To be specific, I was thinking the regex would be:

const RX_CAPS = /(?!^)([A-Z][a-z0-9]+|[A-Z][A-Z0-9]+(?=[A-Z]|\b))/g

instead of

const RX_CAPS = /(?!^)([A-Z][a-z0-9]+|[A-Z][A-Z0-9]*(?=[A-Z]|\b))/g

[ahwatts]

I don't necessarily have a problem with that change, but it does have the potential issue that it won't recognize single-letter "words" at the end of the name.

For example, an action called actionA would turn in to ACTIONA instead of ACTION_A.

It also would break the consecutive-capitals-as-one-word rule:

actionAStar would be ACTIONA_STAR instead of ACTION_ASTAR.

[jkeam]

Ya good point. Thanks again for all your help and contribution. I'm going to merge this into develop and then most likely fix the package json in another PR.

[ahwatts]

Can we get this in to a release soon?

[jkeam]

Ya! Thanks for following back up. I wanna say by the end of this week. I'll drop a note here once it's been released.

[ahwatts]

Thanks!

…

On Mon, Jul 27, 2020 at 1:27 PM Jonathan Keam ***@***.***> wrote: Ya! Thanks for following back up. I wanna say by the end of this week. I'll drop a note here once it's been released. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#99 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACLMFTKA55O7TCNCEGVNUTR5W2H5ANCNFSM4KM3W5HA> .

[jkeam]

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀