Skip to content

Commit

Permalink
fix vega config issues (elastic#59737)
Browse files Browse the repository at this point in the history
  • Loading branch information
flash1293 authored and jkelastic committed Mar 12, 2020
1 parent c075430 commit 603e85b
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions src/legacy/core_plugins/vis_type_vega/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,16 @@ import { LegacyPluginApi, LegacyPluginInitializer } from '../../../../src/legacy

const vegaPluginInitializer: LegacyPluginInitializer = ({ Plugin }: LegacyPluginApi) =>
new Plugin({
// TODO: ID property should be changed from 'vega' to 'vis_type_vega'
// It is required to change the configuration property
// vega.enableExternalUrls -> vis_type_vega.enableExternalUrls
id: 'vega',
id: 'vis_type_vega',
deprecations: ({ rename }: { rename: any }) => [
rename('vega.enabled', 'vis_type_vega.enabled'),
],
config(Joi: any) {
return Joi.object({
enabled: Joi.boolean().default(true),
enableExternalUrls: Joi.boolean().default(false),
}).default();
},
require: ['kibana', 'elasticsearch'],
publicDir: resolve(__dirname, 'public'),
uiExports: {
Expand Down

0 comments on commit 603e85b

Please sign in to comment.