Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose fix some typos #24

Closed
wants to merge 1 commit into from
Closed

Conversation

jeis2497052
Copy link

OK to repair a few more typos?

@coveralls
Copy link

coveralls commented Feb 4, 2018

Coverage Status

Coverage remained the same at 68.635% when pulling a82309f on jeis2497052:master into 1573a18 on jkitchin:master.

@jkitchin
Copy link
Owner

jkitchin commented Feb 5, 2018

Why all the whitespace changes? They don't look correct to me, e.g. many of them look like one space less, which would not be multiples of 4.

jkitchin added a commit that referenced this pull request Feb 5, 2018
Also deleted some unneeded code, and cleaned up docstrings.
jkitchin added a commit that referenced this pull request Feb 5, 2018
@jkitchin
Copy link
Owner

jkitchin commented Feb 5, 2018

Thanks for reporting the typos. I have pushed fixes for them in two commits above. I did not merge the PR because there were a lot of white space changes that didn't make sense, and I didn't want to cherry pick the typos, it was easier to just fix them.

@jkitchin jkitchin closed this Feb 5, 2018
@jeis2497052
Copy link
Author

sorry about the whitespace changes. I am using emacs+scimax+emacs Wiki snippet for trailing white space. I will try to debug what went wrong.

@jeis2497052
Copy link
Author

I found out the current markdown mode will change space to tabs without:
https://www.emacswiki.org/emacs/NoTabs
(setq-default indent-tabs-mode nil)
Why would tabs be a choice for markdown ? I thought most docs avoided tabs at all costs.

Sorry again for adding them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants