Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Canonical order of keywords #67

Merged
merged 22 commits into from
Jul 3, 2019
Merged

Update Canonical order of keywords #67

merged 22 commits into from
Jul 3, 2019

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented May 23, 2019 •
edited
Loading

Description

Addresses #48.

  • Makes order of four main keywords (those that are used to generate the path) reflect the path in a consistent manner: tag, lon, year, day.
  • Default tag is now 'model_run' in run_model. 'test' still used in the unit tests (now explicitly defined).
  • Minor documentation updates, including docstrings.
  • PEP8 cleanup of comments.

Type of change

  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)

@jklenzing jklenzing added this to the 0.2.0 Release milestone May 23, 2019
@jklenzing jklenzing changed the title Canonical order Update Canonical order of keywords May 23, 2019
@jklenzing jklenzing merged commit c105f94 into develop Jul 3, 2019
@jklenzing jklenzing deleted the canonical_order branch July 3, 2019 02:20
@jklenzing jklenzing mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathonMSmith JonathonMSmith JonathonMSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jklenzing @JonathonMSmith