-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xarray and other upgrades #75
Conversation
FYI, Maybe you all have run into and/or solved that issue. For me thus far, the solution was to not use f2py, and instead to pass I/O from Python to Fortran either directly via pipes (stdin/stdout), or if there was too much data for pipes then via tempfile.NamedTemporaryFile or similar (using RAM dist where possible). |
setup.cfg
Outdated
@@ -34,4 +34,6 @@ zip_safe = False | |||
packages = find: | |||
install_requires = | |||
numpy | |||
pandas<0.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a comment here within setup.cfg so we don't forget it's just for Travis-I was puzzled till I saw the PR notes.
# FIXME: upper limit on pandas and xarray are just so Travis CI passes python 2.7 tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Adding.
'-o', 'sami2py.x'] | ||
src = ['nrlmsise00_modified.f', 'grid-1.00.f', 'sami2py-1.00.f', 'hwm93.f', 'hwm07e_modified.f90', | ||
'apexcord.f90', 'hwm14.f90'] | ||
cmd = ['gfortran', '-fno-range-check', '-fno-automatic', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This I think is fine for now. A more general approach for the future to consider is to have a sami2py.build()
function that is automatically run on import sami2py
if the Fortran module isn't built yet. I use that technique on my packages. This allows me to not depend on setuptools()
and to switch compilers and options seamlessly/automatically.
But I think for now, probably most people have Gfortran and setuptools--just noting there's a more general way forward if it becomes an issue.
Description
Addresses #63 and #69.
xarray.Dataset
.Type of change
Context
This PR puts basic changes into play until f2py / netCDF is fully incorporated. Version info will eventually be stored in netCDF metadata.
Upper level limits on pandas and xarray not a permanent solution. Required for Travis CI to properly run python 2.7 tests.
Checklist:
develop
(notmaster
) branch