-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytest, testing expansion for neutrals and plots #80
Conversation
assert abs(xlims[0] + 36.3329) < tol | ||
assert abs(xlims[1] - 19.37387) < tol | ||
assert abs(ylims[0] - 84.98926) < tol | ||
assert abs(ylims[1] - 1999.998) < tol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this test is now run twice and the two data sets are slightly different, updates to use a tolerance rather than exact precision.
return float_data[1:-1, :] | ||
return float_data[1:-1] | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure you need the else here. If reshape is True then the second return will be short-circuited by the return inside the if. But this works just as well. Not sure if there's a benefit one way or the other. Perhaps this is more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of readability
Description
@raises()
towith pytest.raises():
test_core_class
now runs for both the formatted and unformatted test sets.Model.plot_lat_alt()
now returns figure handle instead of just plotting.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested via Travis CI and locally.
Checklist:
develop
(notmaster
) branch