Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to setup #81

Merged
merged 7 commits into from
Sep 25, 2019
Merged

Updates to setup #81

merged 7 commits into from
Sep 25, 2019

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Sep 19, 2019

Description

Previously, artificial caps were added to install_requires to smooth over Travis CI tests when running for python 2.7. This is not needed if .travis.yml uses pip install commands beforehand, since the correct version will be installed. If left up to install_requires, the latest version is installed regardless (seems to be unique to the Travis environment).

Also, adds matplotlib as a requirement to install_requires, which was previously missing, and removes 3.4 from documentation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested on travis CI.

Checklist:

  • Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant