Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some protected methods public #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make some protected methods public #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fba7784
Make equalKeys method public
Globegitter Sep 7, 2019
5586e88
Make getBindValues and toPreparedQuery public
Globegitter Sep 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../java/io/github/jklingsporn/vertx/jooq/shared/reactive/AbstractReactiveQueryExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ protected AbstractReactiveQueryExecutor(Configuration configuration) {
super(configuration);
}

protected Tuple getBindValues(Query query) {
public Tuple getBindValues(Query query) {
ArrayTuple bindValues = new ArrayTuple(query.getParams().size());
for (Param<?> param : query.getParams().values()) {
if(!param.isInline()){
Expand All @@ -50,7 +50,7 @@ protected void log(Query query){
}
}

protected String toPreparedQuery(Query query){
public String toPreparedQuery(Query query){
String namedQuery = query.getSQL(ParamType.NAMED);
return namedQuery.replaceAll(pattern, "\\$");
}
Expand Down
4 changes: 2 additions & 2 deletions ...ared/src/main/java/io/github/jklingsporn/vertx/jooq/shared/internal/AbstractVertxDAO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ protected Condition equalKey(T id){
}

@SuppressWarnings("unchecked")
protected Condition equalKeys(Collection<T> ids){
public Condition equalKeys(Collection<T> ids){
UniqueKey<?> uk = getTable().getPrimaryKey();
Objects.requireNonNull(uk,()->"No primary key");
/**
Expand Down Expand Up @@ -248,4 +248,4 @@ private Record setDefault(Record record) {
}

protected abstract T getId(P object);
}
}