Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI modifications - part 2 #45

Merged
merged 23 commits into from
Aug 24, 2017
Merged

GUI modifications - part 2 #45

merged 23 commits into from
Aug 24, 2017

Conversation

samoryka
Copy link

@samoryka samoryka commented Aug 19, 2017

Hello,
I finished my GUI modifications!

App icon

I made an icon. It's a P with two D's stacked below it, as in "ParkenDD".
ic_launcheric_launcher_round

I used this handy website to integrate my design in Android's icon template.
For all the assets I made, I left the PSD file in /resources in case you want to modify them.

Main screen

  • Modification of the colors (they're now based on a gradient)
  • Modification of the layout
    1

Navigation drawer

New layout and illustration in the header
2

Forecast

  • New layout
  • Integrated Android's native time/date picker dialogs
    345

Things I couldn't do (or didn't/won't have the time to do)

  • I translated all the things I made in English and French but not in German since I wasn't always sure of how to translate them.
  • I did not have the time to implement animations in the views (i.e. an expansion animation when a parking spot is expanded in the main list).

Things you could look into

  • There are cool libraries made to simplify network communication in Java, notably Retrofit combined with RxJava. I think it could help you avoid having to implement LoaderInterface in all views interacting with the network.
  • To simplify the binding of XML layouts and Java views, you could use ButterKnife.

Misc.

  • I updated the target SDK/build tools version, in my case it didn't cause any problem.
  • I updated the Readme of the project.
  • Unfortunately, I won't have more time to work on ParkenDD, my next semester in France will begin pretty soon and there are some technologies I'd like to learn before the end of the year.
    I hope that you like my modifications and wish you all the best for the future of the project :). I was happy to be able to work a bit on it!

@jklmnn jklmnn self-assigned this Aug 20, 2017
@jklmnn
Copy link
Owner

jklmnn commented Aug 20, 2017

Thanks for your work! From what I see on the screenshots it looks great. I especially like the new date picker. I tried to do that but couldn't come up with a satisfying solution so I'm happy you fixed that.
I probably won't use the logo. We are currently thinking about renaming the project since the DD is bound to much to Dresden but we have many more cities now. And since (not yet known) new name should involve something with parking and open data, the current logo would fit better.

Don't worry about the translation, I'll do that. We also need to adapt the Polish and Czech translations so that needs to be done anyway (by someone else). I'll see where animations fit and where I'm able to implement them, thats also no big problem.
I'll see if I refactor the project some time and use libraries to simplify the code but unfortunately my free time is quite limited. But thanks for the tips. I'll definitely will look into it when we are going to deploy the next API version (which doesn't exist but the current approach limits the data we can use and provide) and the network code needs to be rewritten from scratch then.

Thanks for updating the build tools and the readme. That was something that needed to be done anyway and I'm glad you did it.

Thanks for your time, you helped this project much! I wish you luck and success in your studies!
If you want to, I can mention you on the project website under Licenses in your preferred way (link to your GitHub profile, your name, link to your website, etc.)

Some notes:
I'll look through the code this week, I hope I get it done by Friday. I'll manually merge this PR into staging instead of master first since master contains some small UI fixes that obviously don't apply to your work. I also need to do some finishes (such as translations) that will take some time. But when everything is finished, I'll put it to master and release it.

@samoryka
Copy link
Author

@jklmnn
Ok, great! You're very welcome :).
Indeed, renaming seems like a smart decision.

I'd gladly be mentioned on the project's website with my name and GitHub profile.

@jklmnn jklmnn merged commit e10ea7f into jklmnn:staging Aug 24, 2017
@jklmnn jklmnn mentioned this pull request Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants