Create POMs for installation process #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rakoenig
commented
Aug 24, 2023
•
rakoenig
commented
- Related ticket: https://progress.opensuse.org/issues/132890
- Verification run: https://openqa.opensuse.org/tests/3537791
- Added InstallActor to all tests: Verification runs
jknphy
reviewed
Aug 24, 2023
rakoenig
force-pushed
the
monitor_installation
branch
5 times, most recently
from
2483263
to
70467d6
Compare
jknphy
reviewed
Aug 25, 2023
rakoenig
force-pushed
the
monitor_installation
branch
from
3183a12
to
bb3eaee
Compare
jknphy
reviewed
Aug 25, 2023
jknphy
reviewed
Aug 25, 2023
jknphy
reviewed
Aug 27, 2023
rakoenig
force-pushed
the
monitor_installation
branch
4 times, most recently
from
3dfb91b
to
568ed2e
Compare
jknphy
reviewed
Sep 1, 2023
pages/installing-page.ts
Outdated
| @@ -0,0 +1,16 @@ | |||
| import { expect, type Locator, type Page } from '@playwright/test'; | |||
|
|
|||
| export class InstallationProgressPage { | |||
There was a problem hiding this comment.
should be called InstallingPage as mentioned in other comment, file name should match with class name.
jknphy
reviewed
Sep 1, 2023
tests/full-disk-encryption.spec.ts
Outdated
| @@ -7,6 +7,10 @@ import { EncryptionPasswordPopup } from '../pages/encryption-password-popup'; | |||
| import { UsersPage } from '../pages/users-page'; | |||
| import { DefineUserPage } from '../pages/define-user-page'; | |||
| import { ConfigureRootPasswordPage } from '../pages/configure-root-password-page'; | |||
| import { ConfirmInstallationPage } from '../pages/confirm-installation-page'; | |||
There was a problem hiding this comment.
besides this test, there are others that needs this improvement.
rakoenig
force-pushed
the
monitor_installation
branch
from
568ed2e
to
43f9055
Compare
rakoenig
force-pushed
the
monitor_installation
branch
from
43f9055
to
67428d6
Compare
lemon-suse
approved these changes
Oct 17, 2023
lemon-suse
approved these changes
Oct 17, 2023
|
LGTM, could we implement the install-actor for other test cases for installation part such as lvm, encrypted_lvm, etc? |
rakoenig
force-pushed
the
monitor_installation
branch
from
67428d6
to
3c51bef
Compare
rakoenig
force-pushed
the
monitor_installation
branch
from
3c51bef
to
d4dfab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.