Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetcher loses ability to write and delete files #20

Closed
jkomoros opened this issue Jan 14, 2024 · 0 comments
Closed

Fetcher loses ability to write and delete files #20

jkomoros opened this issue Jan 14, 2024 · 0 comments

Comments

@jkomoros
Copy link
Owner

That's instead handled in the dataManager layer entirely, which wirtes into localFilesystem

We don't save compiled files out and the tooling fetches the compiled data and saves out instead of assuimign the sprout will.

Related to #19
jkomoros added a commit that referenced this issue Jan 15, 2024
@jkomoros
Make it so Sprout doesn't writeFile.
f01c568 
This requires twweaking how npm run generate:sprouts saves sprouts to make it the responsibility of the tool to save the file out.

Part of #20.
@jkomoros jkomoros mentioned this issue Jan 15, 2024
Closed
jkomoros added a commit that referenced this issue Jan 15, 2024
@jkomoros
Fetchers get writeSprout and deleteSprout.
e31f664 
They should fail if writeable(sproutName) is false.

This is a kind of coneceptual undo of #20.

DataManager in app now gets much more simple.

Now that we have MetaFetcher, it's cleaner for the same fetcher that knows how to fetch a given subdirectory knows how to write to those, too.

Fixes #22.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkomoros