Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize nested fetchers #21

Closed
8 tasks done
jkomoros opened this issue Jan 15, 2024 · 1 comment
Closed
8 tasks done

Rationalize nested fetchers #21

jkomoros opened this issue Jan 15, 2024 · 1 comment

Comments

@jkomoros
Copy link
Owner

jkomoros commented Jan 15, 2024

Rationalize concept of OverlayFetcher, BrowserFetcher, NodeFetcher, etc.

Currently BrowserFetcher has a localWriteablePath that it traps out to LocalFilesystem.

Instead, create a FilesystemFetcher, (and in other cases, you might have e.g. a FirebaseFetcher).

Fetcher grows a validPath() which errors if it's a prefix this fetcher doesn't know how to deal with.

And then add a MetaFetcher, that takes a default fetcher, and then can registerHandler(pathPrefix, subFetcher) that will be called out to when it matches.

Fetcher.listSprouts() doesn't take paths, it just is supposed to list any sprouts it knows of. And the MetaFetcher calls sub ones.

Related to #19

  • remove localWriteablePath
  • Delete overlayFetcher
  • fetcher-filestystem -> fetcher-localstorage
  • Create fetcher-directoryinfo
  • Remove localWriteablePath from every fetcher
  • Remove overlayFetcher
  • Move fetchers to be in src/fetchers
  • Sprout has a metaFetcher, not a fetcher. (in app, instead of localWriteablePath, hook a Filesystem sub path)
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
jkomoros added a commit that referenced this issue Jan 15, 2024
@jkomoros
Copy link
Owner Author

Finished as of aa4638b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant