Allow remote seed packets #3

jkomoros · 2023-06-17T22:02:55Z

Allow seeds to reference seeds in other packets based on relative location (normalize nested references on packet planting based on the packet location)
Allow https absolute paths and fetching
Document regex types with describe
Seed should immediately return Plant() which has a value() that you await. This will be the way to expose intermediate results of sub-seeds.
Actually support mocked garden.fetchRemoteSeedPacket and test
A way to fetch all sub-seed referenced locations up front and validate the references before starting a compuation (check for loops in graphs)
Add a test for loading a seed in another packet that was already loaded, and then also one that must be loaded due to that reference
Use new URL() with a file://localhost/foo file for relative

The text was updated successfully, but these errors were encountered:

Part of #3.

…n location. Part of #3.

(This was already true in the last few commits but typechecking didn't detect it because they're both strings). Part of #3.

…ere the reference is explicitly set to '.'. Part of #3.

Part of #3.

…seedReferenceID, etc. These descriptions shou up in the messages in schema validation. Part of #3.

Part of #3.

…object. Munging things into strings was very error prone and hard to verify things parsed right. This makes it way, way easier for users to detect errors earlier. Part of #3.

…renceToString. Part of #3.

…es it needs. This cleans up needing to change a billion call sites in every growFoo every time we want a sub-seed to get more information. Part of #3.

Part of #3.

… through unmodified. Part of #3.

Part of #3.

This is because soon we'll fetch a seed packet if a seed that requires it is loaded. Part of #3.

Part of #3.

promise. Part of #3.

Fetching requires a 'fs' import, which we don't want to do in a browser context. So it will have to be injected in. Part of #3.

Part of #3.

…injected. Part of #3.

… to install a local fetcher. Part of #3.

…s called for a location not yet loaded, it tries to fetch the seed packet first. Part of #3.

Since now SeedReferences are objects and not strings, there's no need to have a different name. Part of #3.

Part of #3.

…ileLocation and makeAbsolute to work with https:// . Part of #3.

Part of #3.

…etchSeedPacket choose between them. fetchRemoteSeedPacket is currently a stub. Part of #3.

…h API. Part of #3.

Part of #3.

…absolute location. Part of #3.

Part of #3.

jkomoros added a commit that referenced this issue Jun 18, 2023

Pop out notions of LocalSeedID and SeedReference.

9819c75

Part of #3.

jkomoros added a commit that referenced this issue Jun 18, 2023

Verify LocalSeedIDs have limited characters in them.

13f0022

Part of #3.

jkomoros added a commit that referenced this issue Jun 18, 2023

Add SeedPacketLocation type.

5ce0a0f

Part of #3.

jkomoros added a commit that referenced this issue Jun 18, 2023

Add a TODO on type checking.

3973d9c

Part of #3.

jkomoros added a commit that referenced this issue Jun 18, 2023

Make plantSeedPacket take a location.

49e4c3c

Part of #3.

jkomoros added a commit that referenced this issue Jun 18, 2023

Garden keeps track of the location of the first planted seed packet.

76ac06d

Part of #3.

jkomoros added a commit that referenced this issue Jun 21, 2023

Add a unpackSeedReferenceID util function.

a5bca89

Part of #3.

jkomoros added a commit that referenced this issue Jun 21, 2023

Define packSeedReferenceID

4e72ac1

Part of #3.

jkomoros added a commit that referenced this issue Jun 21, 2023

Add a default to unpackSeedReferenceID when location is not provided.

16a02b1

Part of #3.

jkomoros added a commit that referenced this issue Jun 21, 2023

Make it so seeds are planted in different locations in garden based o…

fa360f6

…n location. Part of #3.

jkomoros added a commit that referenced this issue Jun 21, 2023

Make Seed.id be a SeedReferenceID, not a LocalSeedID.

3b5427f

(This was already true in the last few commits but typechecking didn't detect it because they're both strings). Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

unpackSeedReferenceID handles a case with a reference like #test wh…

f072ff3

…ere the reference is explicitly set to '.'. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Update locationRegExp and seedReferenceID regexp to match.

27d0c5b

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Add good descriptions for the match patterns for seedPacketLocation, …

deb40cc

…seedReferenceID, etc. These descriptions shou up in the messages in schema validation. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

A small clarifying comment.

90a5b18

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Add Seed.location.

2ce5676

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Add isSeedReference.

eb52f62

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Made error messages a bit better for seed retrieval. Created seedRefe…

d4b6571

…renceToString. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Formatting import.

3887988

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Make it so growLog doesn't coerce a sub-seed to string, but passes it…

44093c9

… through unmodified. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Test that growing a seed in a file that is already loaded works.

0d0e1f1

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Made it so garden.seed() returns a promise.

16ce824

This is because soon we'll fetch a seed packet if a seed that requires it is loaded. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Make it so eslint doesn't yell for unused parameters that start with _.

78c5bca

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Fix a test that broke when garden.seed() began returning a

2d90892

promise. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Made it so a garden can have a fetcher injected at construction time.

4543998

Fetching requires a 'fs' import, which we don't want to do in a browser context. So it will have to be injected in. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Change type of fetcher to return a promise.

b9c0f7b

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Make it so gardens loaded using loadLocalGarden get the JSON fetcher …

0dbfeaf

…injected. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Make it so loadTestGarden takes an override list of files and whether…

2fc671c

… to install a local fetcher. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Garden grows ensureSeedPacket and fetchSeedPacket. If garden.seed() i…

a6e78c8

…s called for a location not yet loaded, it tries to fetch the seed packet first. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

LocalSeedID -> SeedID.

c89b5b0

Since now SeedReferences are objects and not strings, there's no need to have a different name. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Pop out SeedPacketAbsoluteLocalLocation in prep for starting https.

9f7d955

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Add a SeedPacketAbsoluteRemoteLocation and change the behavior of isF…

9207866

…ileLocation and makeAbsolute to work with https:// . Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

isFileLocation --> isLocalLocation to match naming scheme.

cffb568

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Factor out fetchLocalSeedPacket and fetchRemoteSeedPacket, and have f…

a87263d

…etchSeedPacket choose between them. fetchRemoteSeedPacket is currently a stub. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Make it so fetchRemoteSeedPacket actually fetches them using the fetc…

dd80bf9

…h API. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Make the default seed packet have an example remote packet.

b4fbb2c

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Update a TODO

78ddfca

Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

Big commit. Made it so it's just a SeedReference, with a relative or …

8202c8e

…absolute location. Part of #3.

jkomoros added a commit that referenced this issue Jun 24, 2023

SeedReference.location --> packet

8e86176

Part of #3.

jkomoros mentioned this issue Jul 1, 2023

Add caching and intermediate results #25

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow remote seed packets #3

Allow remote seed packets #3

jkomoros commented Jun 17, 2023 •

edited

Loading

Allow remote seed packets #3

Allow remote seed packets #3

Comments

jkomoros commented Jun 17, 2023 • edited Loading

jkomoros commented Jun 17, 2023 •

edited

Loading