-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShellCheck #24
Comments
Yes, ShellCheck was used (fairly extensively) as I was writing forkrun. All the shellcheck warnings shown fall into one of four categories:
I could safely disable SC2004 and SC1090, as these particular rules can always be safely ignored, but the rest are cases where in that specific situation the rule doesnt apply, not cases where the rule should unilaterally never apply, so I wouldnt want to disable those. |
If you want you can just add a comment like
And it will only impact the following line/block (Having zero warnings is the easiest way to notice when a new unintentional warning occurs) |
I just pushed a update to the main branch that bumps the version to forkrun v1.1. The main new feature is support for splitting up stdin based on the number of bytes read (supported by 2 new flags: -b and -B), but one of the smaller miscellaneous changers was to globally disable many of the not-really-useful/applicable shellcheck warnings. I havent gone through and line-by-line disabled the 20 or so shellcheck warnings that are useful warnings in general but dont apply to that specific line. At some point once forkrun is more-or-less "stable and complete" and not still having new features actively developed Ill probably add these line-by-line shellcheck disable directives. Im going to go ahead and close this issue. Thanks for taking the time to submit it! |
Do you use ShellCheck in your IDE?
It has some issues with this code that should be fixed or marked as an exception.
The text was updated successfully, but these errors were encountered: