-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing OrderType in OrderTypeConverter #1
Comments
Hm that's interesting. I'll add it to the enum. Do you know if there are any other types which might not be in the enum? I implemented the order types enum according to the Kraken api documentation at https://www.kraken.com/features/api#add-standard-order . The |
Fixed in the latest version |
An order type from Kraken JSON data shows "ordertype": "stop market", which looks to be missing from the converter.
Error:
Cannot map enum. Type: Kraken.Net.Objects.OrderType, Value: stop market
Exception thrown: 'System.NullReferenceException' in Newtonsoft.Json.dll
Method:
var history = await client.GetTradeHistoryAsync(resultOffset: offset);
"TDSUTH-DO3XV-V67G37": {
"ordertxid": "ODBUJA-CTRWB-YJSTLF",
"postxid": "T5XXXZ-KAHYB-W6RQKR",
"pair": "XXBTZUSD",
"time": 1483734622.6224,
"type": "sell",
"ordertype": "stop market",
"price": "877.55000",
"cost": "1652.37592",
"fee": "4.29618",
"vol": "1.88294218",
"margin": "550.79197",
"misc": "closing"
},
I can send full JSON if needed.
The text was updated successfully, but these errors were encountered: