Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing enum in Kraken.Net.Objects.LedgerEntryType #2

Closed
dlmac opened this issue Sep 23, 2019 · 2 comments
Closed

Missing enum in Kraken.Net.Objects.LedgerEntryType #2

dlmac opened this issue Sep 23, 2019 · 2 comments

Comments

@dlmac
Copy link

dlmac commented Sep 23, 2019

Found three missing Ledger "type": transfer, adjustment, and rollover.

I have modified LedgerEntryTypeConverter locally to confirm all 3 types. I have a feeling they do not maintain the documentation very well.

image

Method:
var history = await client.GetLedgerInfoAsync(resultOffset: offset);

Error #1
Cannot map enum. Type: Kraken.Net.Objects.LedgerEntryType, Value: adjustment

"LDSTHP-UO35K-KXKKJM": {
"refid": "LAYP6WA-ECW7A-S3MWLS",
"time": 1549990358.3277,
"type": "adjustment",
"aclass": "currency",
"asset": "XETH",
"amount": "0.0000000054",
"fee": "0.0000000000",
"balance": "0.0000000054"
},

Error #2
Cannot map enum. Type: Kraken.Net.Objects.LedgerEntryType, Value: transfer

"L3NFOL-7ZM44-EUC6HM": {
"refid": "LAAYEYA-ZXI7T-Y6C7TQ",
"time": 1542583842.8385,
"type": "transfer",
"aclass": "currency",
"asset": "BSV",
"amount": "0.0007546220",
"fee": "0.0000000000",
"balance": "0.0007546220"
},

Error #3
Cannot map enum. Type: Kraken.Net.Objects.LedgerEntryType, Value: rollover

"LTXJVD-Z6D4N-OW7VXI": {
"refid": "TX64AJ-X2FFM-22FEQG",
"time": 1484082682.0106,
"type": "rollover",
"aclass": "currency",
"asset": "ZUSD",
"amount": "0.0000",
"fee": "0.4580",
"balance": "657.2565"
}

@JKorf
Copy link
Owner

JKorf commented Sep 24, 2019

I share that feeling with you. I've added the missing types and created a new version, 0.0.3 should be available in a few minutes. Thanks for your detailed reports! I personally don't use Kraken a lot, so please let me know if you find anything else as it helps me improve the library.

@dlmac
Copy link
Author

dlmac commented Sep 25, 2019

Thank you. I don't either. Their UI, API leaves a lot to be desired.

@JKorf JKorf closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants