Fix bug when using default get limit. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: The existing code passed 0 as the default page size limit when calling getArtists, getAlbums or getTracks. However, this resulted in a response from last.fm that contained the right data, but had empty strings as the the page, perPage and totalPages attributes. These attributes then failed to parse in ResponseBuilder, resulting in a NumberFormatException. To Reproduce: Call Library.getArtists(String user, String apiKey) on a library with less than 50 artists. Fix: To fix this I changed the library get methods (Library.getArtists, Library.getAlbums and Library.getTracks) to omit the limit parameter if limit <= 0. This results in last.fm using its default limit, which is currently 50, and the response has the appropriate page, perPage and totalPage attributes set, eliminating the parsing issue in ResponseBuilder.
jkovacs
added a commit
that referenced
this pull request
Dec 17, 2013
Fix bug when using default get limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
The existing code passed 0 as the default page size limit when calling
getArtists, getAlbums or getTracks. However, this resulted in a response
from last.fm that contained the right data, but had empty strings as the
the page, perPage and totalPages attributes. These attributes then
failed to parse in ResponseBuilder, resulting in a
NumberFormatException.
To Reproduce:
Call Library.getArtists(String user, String apiKey) on a library with
less than 50 artists.
Fix:
To fix this I changed the library get methods (Library.getArtists,
Library.getAlbums and Library.getTracks) to omit the limit parameter
if limit <= 0. This results in last.fm using its default limit, which is
currently 50, and the response has the appropriate page, perPage and
totalPage attributes set, eliminating the parsing issue in
ResponseBuilder.