Skip to content
This repository has been archived by the owner on Jun 8, 2019. It is now read-only.

Variety of improvements #11

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

ngbrown
Copy link

@ngbrown ngbrown commented Sep 9, 2011

Hello,

I've been making incremental changes to NLog for awhile. The highlights are:

  • Change the level at which the Trace output will show a fault. - Warns were showing a dialog box, which was annoying. I left fatal as fatal in Trace, thus it shows a message box, but passing the error level is unique to NLog and didn't happen in log4net.
  • Add Nullable property and capability to database parameters. Allows nulls for exceptions and empty strings.
  • Added generic based GetLogger for faster logger creation and better refactoring - Since passing typeof() is much faster at creation than looking at the stack trace, I also changed the snippet for C# to use the class name.
  • Set VB snippet to shared (static).

Also included are some commits from other branches.

  • Fixed documentation of LogLevel.FromOrdinal to match implementation
  • Set DeliveryMethod to Network in MySmtpClient.cs
  • Add support for logging .Net logical thread ActivityIds.

@jkowalski
Copy link
Owner

Hi Nathan,

Unfortunately NLog project is not accepting 3rd party code patches at
this time (legal reasons which I'm trying to resolve). Can you file
bugs for all the improvements you made and I'll try to implement those
and check them in.

Looking at your checkin comments, they all seem like good
improvements. Sorry about this extra process for now.

Jarek

@eric-newton
Copy link

Did these legal reasons get resolved?

@damianh
Copy link

damianh commented Jan 28, 2013

@jkowalski > NLog project is not accepting 3rd party code patches

How about you put a statement to that effect in the README.rdoc so people don't waste their time ?

@badmotorfinger
Copy link

Is there a reason NLog will not accept 3rd party patches? Either way it doesn't matter, we can all modify our shallow forks but just curious.

@jkowalski
Copy link
Owner

Go to "nlog/NLog" - it's a new official fork of NLog which does accept patches.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
8 participants