Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ajax Autocomplete #6

Merged
merged 22 commits into from
Feb 12, 2014
Merged

[FEATURE] Ajax Autocomplete #6

merged 22 commits into from
Feb 12, 2014

Conversation

IndyIndyIndy
Copy link
Contributor

fixes #5

@jkphl
Copy link
Member

jkphl commented Jan 28, 2014

@IndyIndyIndy Wow, thanks a lot! Will have a look at this ASAP (probably tomorrow).

jkphl added a commit that referenced this pull request Feb 12, 2014
[FEATURE] Ajax Autocomplete
@jkphl jkphl merged commit daff241 into tollwerk:master Feb 12, 2014
@jkphl
Copy link
Member

jkphl commented Feb 12, 2014

@IndyIndyIndy Finally working on the search now — thanks for this awesome enhancement! Will review it further the next days, more features to come as well! :)

@jkphl
Copy link
Member

jkphl commented Feb 12, 2014

@IndyIndyIndy I'm about revising your autocomplete addition, and I've got a couple of questions:

  1. What happens if someone enters two or more words into the search input (separated by whitespace). Is the whole entry to be treated as a phrase? At the moment, it is not ...
  2. The regular search supports some rewrite hooks for the search terms submitted. I would expect the autocomplete feature to yield the same results as the regular search, which would require to apply the rewrite hooks as well. Is there a reason why you didn't implement these hooks into the autocomplete search as well?
  3. Similar applies to the support for language and rootline based restrictions: The regular Lucene query is generated by the query() method, which is taking care of these restrictions. Any reason you didn't implement this? Which basically means, that you will also get autocomplete in other languages than the current, or from different page trees (in case you've got a multiple tree TYPO3 instance).

Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Ajax Autocomplete
2 participants