Improved code climate

jkphl · Mar 5, 2017 · 1892b93 · 1892b93
1 parent 384bdda
commit 1892b93
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 10 deletions.
diff --git a/src/Micrometa/Application/Factory/ItemFactory.php b/src/Micrometa/Application/Factory/ItemFactory.php
@@ -89,19 +89,31 @@ protected function getProperties(\stdClass $item)
         $properties = [];
         if (isset($item->properties) && is_array($item->properties)) {
             foreach ($item->properties as $propertyName => $propertyValues) {
-                try {
-                    $expandedPropertyValues = $this->getPropertyValues($propertyValues);
-                    if (count($expandedPropertyValues)) {
-                        $properties [$propertyName] = $expandedPropertyValues;
-                    }
-                } catch (InvalidArgumentException $e) {
-                    continue;
-                }
+                $this->processPropertyValues($properties, $propertyName, $propertyValues);
             }
         }
         return $properties;
     }
 
+    /**
+     * Process the values of a property
+     *
+     * @param array $properties Properties
+     * @param string $propertyName Property name
+     * @param array $propertyValues Property values
+     */
+    protected function processPropertyValues(array &$properties, $propertyName, $propertyValues)
+    {
+        try {
+            $expandedPropertyValues = $this->getPropertyValues($propertyValues);
+            if (count($expandedPropertyValues)) {
+                $properties[$propertyName] = $expandedPropertyValues;
+            }
+        } catch (InvalidArgumentException $e) {
+            // Skip this property
+        }
+    }
+
     /**
      * Prepare item property values
      *
@@ -119,7 +131,7 @@ protected function getPropertyValues($propertyValues)
         }
 
         return array_map(
-            function($propertyValue) {
+            function ($propertyValue) {
                 return is_object($propertyValue) ? $this->__invoke($propertyValue) : $propertyValue;
             },
             $propertyValues

diff --git a/src/Micrometa/Infrastructure/Parser/ParsingResult.php b/src/Micrometa/Infrastructure/Parser/ParsingResult.php
@@ -52,7 +52,7 @@ class ParsingResult implements ParsingResultInterface
     /**
      * Extracted items
      *
-     * @var \stdClass[]
+     * @var ItemInterface[]
      */
     protected $items;
     /**