Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some php81 deprecations #73

Merged
merged 3 commits into from Dec 22, 2022
Merged

fix some php81 deprecations #73

merged 3 commits into from Dec 22, 2022

Conversation

jspaetzel
Copy link
Contributor

@jspaetzel jspaetzel commented Jul 9, 2022 •
edited

see a build before: https://github.com/jkphl/micrometa/runs/6471810846?check_suite_focus=true
and after, https://github.com/jkphl/micrometa/runs/7260473231?check_suite_focus=true
Haven't fixed them all but here's a start. A couple of them are tricky without also dropping lower version support.

@jspaetzel jspaetzel changed the title fix deprecations fix php81 deprecations Jul 9, 2022
@coveralls
Copy link

coveralls commented Jul 9, 2022 •
edited

Coverage Status

Coverage remained the same at 98.699% when pulling 26366f0 on jspaetzel:fix_php8_deprecations into 5799bb4 on jkphl:master.

@jspaetzel jspaetzel changed the title fix php81 deprecations fix some php81 deprecations Jul 9, 2022
@serzhik serzhik mentioned this pull request Nov 7, 2022
Closed
@rvanlaak rvanlaak self-requested a review November 7, 2022 14:45
rvanlaak
rvanlaak approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@rvanlaak rvanlaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rvanlaak rvanlaak merged commit 61f9064 into jkphl:master Dec 22, 2022
@jspaetzel jspaetzel deleted the fix_php8_deprecations branch December 23, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvanlaak rvanlaak rvanlaak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jspaetzel @coveralls @rvanlaak