-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version of SVGO 1.1.0 breaks svg-sprite #276
Comments
It is fixed with this version: https://github.com/svg/svgo/releases/tag/v1.1.1 svg-sprite should raise the dependency to ^1.1.1 |
@jonnitto Awesome, thank you! Will do as soon as I find some minutes. |
Thank you for your work! |
Please update if https://github.com/svg/svgo/releases/tag/v1.1.1 tag has been updated in package.json of svg-sprite of 1.4.0 tag. Since we are using gulp-svg-sprite 1.4.0 and which in turn using svg-sprite 1.4.0. This is causing lot of build breaks in multiple projects. So, early response from you will be highly appreciated. |
@AKrishma I think you should be able to fix your local by clearing your |
@longzheng, provided worked for us. |
I'm just working on updating the dependencies, especially the SVGO one. Unfortunately, updating SVGO doesn't fix the package tests for me, I'm still getting these |
@longzheng Will try (although SVGO already seems to be successfully updated to 1.1.1). Also, seems that some other dependencies require higher node versions in the meantime, so this might even end up in a version 1.5 for |
Sorry my bad, I misread your message. |
Just putting it out there, maybe another of the dependencies you updated is causing a different issue now? Have you tried just doing one build where you only update |
@longzheng Yeah, tried that, but there's no difference. The error messages are still about the same |
Ok, I'm a node noob but I figured out the actual cause of the exception was not I checked out your commit When running the tests, this line https://github.com/jkphl/svg-sprite/blob/b9a2df3702d6f7322d6f0bc3df2edcdab88a9a14/lib/svg-sprite/transform/svgo.js#L83 was causing an exception
Inspecting I have no context of what this is or why it has been changed (another dependency breaks it?) but that's the actual error. If i change to |
Set up a demo #277 The tests still fail, but it's failing on sprites not matching. |
@longzheng Awesome, thanks for the pointer! This must be it! I'm just back from my meeting and will look at it asap. Looks like this is something related to winston (the logger used by svg-sprite). Btw, errors because of non-matching sprites are usually harmless and the result of minor (= sub-pixel) rendering changes in image comparing libraries. |
I just pushed out the release |
svgo
just released 1.1.0 on npm which seems to breaksvg-sprite
.It seems to have broken a lot of other third-party tools as well, I believe this is related svg/svgo#1030
The text was updated successfully, but these errors were encountered: