Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkphl: unsure if the package is still maintained but since we are still using it, I thought I'd make a PR. I could split some of the changes if needed.
There are failing tests even on master on Node.js >=12. I think the test PNGs need to be updated and also:
svg2png; the current version breaks on Node.js 15I updated it, but needs another pair of eyesnode-sass; the current version does not work on Node.js 15mocha; still works thoughistanbul should be replaced with nyc because it's deprecatedreplace it with c8pn can be removed and use Node.js'sutil.promisify
The rest of the deps shouldn't matter but my guess is Node.js < 10 support will need to be dropped.Edit, dropped it since more and more deps don't work there.This should fix any lgtm.com issues. I also added a CodeQL action which is the successor to CodeQL, but ideally you could use both.