Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image output scaling #96

Closed
nmielcarek opened this issue Apr 24, 2023 · 2 comments
Closed

Image output scaling #96

nmielcarek opened this issue Apr 24, 2023 · 2 comments
Assignees
@jkriege2
Labels
bug oddities & peculiarities

Comments

@nmielcarek
Copy link

Greetings,

I'm curious why this 1.1 scaling factor exists here in JKQTBasePlotter::saveAsPixelImage:
https://github.com/jkriege2/JKQtPlotter/blob/master/lib/jkqtplotter/jkqtpbaseplotter.cpp#L4002

Whenever I try to save a png image, it always creates an empty transparent region around the plot due to that extra scaling which isn't desired.

OS: Linux (Fedora 36)

Thanks for the great library!
-Nathan
@jkriege2 jkriege2 self-assigned this May 30, 2023
@jkriege2
Copy link
Owner

Hmmm ... I think that's a remenant of (very?) old code ... I will look into this. Basically I agree that this is unneccesary.

PS: Sory fpr the late answer!

jkriege2 added a commit that referenced this issue Jul 1, 2023
@jkriege2
fix issue #96: JKQTPlotter::saveAsPixelImage() does not add a border …
d23ea0a 
…around the image any longer (can be reacivated by a new optional function parameter)
@jkriege2
Copy link
Owner

jkriege2 commented Jul 1, 2023

fixed via d23ea0a

@jkriege2 jkriege2 closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkriege2 jkriege2

Labels
bug oddities & peculiarities
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nmielcarek @jkriege2