Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Commit

Permalink
Give the possibilities to change nickname
Browse files Browse the repository at this point in the history 
Fix the problem that doesnt want to change the nickname of the player
  • Loading branch information
@Jbaukens
Jbaukens committed Apr 5, 2016
1 parent 61e9086 commit a5e3a69
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions includes/pages/game/ShowSettingsPage.class.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ private function sendDefault()

if (!empty($username) && $USER['username'] != $username)
{
if (PlayerUtil::isNameValid($username))
if (!PlayerUtil::isNameValid($username))
{
$this->printMessage($LNG['op_user_name_no_alphanumeric'], array(array(
'label' => $LNG['sys_back'],
Expand Down Expand Up @@ -421,4 +421,4 @@ private function sendDefault()
'url' => 'game.php?page=settings'
)));
}
}
}

2 comments on commit a5e3a69

@OzanKurt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkroepke I don't think it's a nice thing to give users hands. People recognize each other with their usernames and there are places where we store usernames as string instead of a reference to the id in users table. This would also cause conflicts in such situations.

@jkroepke
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be configable via admin panel, yes.

Please sign in to comment.