Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

fix moon destruction bug #187

Closed
wants to merge 2 commits into from
Closed

fix moon destruction bug #187

wants to merge 2 commits into from

Conversation

Jbaukens
Copy link
Contributor

fix problem #181 there should probably be a better code but atleast it work, so you might adapt it and you know what the problem was

Regards

@jkroepke
Copy link
Owner

jkroepke commented Jun 3, 2016

HI!

I will decline this pull request, because this problem does exist on all missions. We need a more generic way instead modify a single mission file.

@jkroepke jkroepke closed this Jun 3, 2016
@Jbaukens
Copy link
Contributor Author

Jbaukens commented Jun 4, 2016

Hi i do agree and i do not agree
The problem could happen on all mission but destruction mission is the only where a planet can disipaer when something is going to all others missions (attack spy...) can not happen because you are not allowed to delete a planet when you have incomming fleets
Regards

@jkroepke
Copy link
Owner

jkroepke commented Jun 6, 2016

Normally, this should be never happens. If the target moon/planet does not exist, it should raise an exception.
The bug you fixed in #181 avoid this problem, too.

It is always better to raise exceptions instead silence them away. Or we need to implement a log system in 2moons.

jkroepke pushed a commit that referenced this pull request Aug 18, 2019
Unused class ingame + php7.2+ supp
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants